Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Catch sync/async exceptions in interceptors' handlers" #2169

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Revert "Catch sync/async exceptions in interceptors' handlers" #2169

merged 3 commits into from
Mar 28, 2024

Conversation

AlexV525
Copy link
Member

Reverts #2139
Fixes #2167
Reopen #2138

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Added tests were fake, so they remained effective after the revert.

@AlexV525 AlexV525 added p: dio Targeting `dio` package s: bug Something isn't working b: regression Worked before but not now 🚒 URGENT Needs to be resolved immediately labels Mar 28, 2024
@AlexV525 AlexV525 self-assigned this Mar 28, 2024
@AlexV525 AlexV525 requested a review from a team as a code owner March 28, 2024 03:23
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage Report

Package Base Coverage New Coverage Difference
dio 🟢 80.26% 🟢 81% 🟢 0.74%
Overall Coverage 🟢 80.26% 🟢 81% 🟢 0.74%

Minimum allowed coverage is 0%, this run produced 81%

@AlexV525 AlexV525 merged commit d256629 into main Mar 28, 2024
3 checks passed
@AlexV525 AlexV525 deleted the revert/2139 branch March 28, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexV525 AlexV525

Labels
b: regression Worked before but not now p: dio Targeting `dio` package s: bug Something isn't working 🚒 URGENT Needs to be resolved immediately
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interceptor onError handling broken
1 participant
@AlexV525